Paolo Bonzini has posted comments on this change.
Change subject: core: allow read-only for VirtIO-SCSI DirectLUN disks
......................................................................
Patch Set 1: Code-Review-1
I think this patch is incorrect, unfortunately. If you change 'lun' to 'disk'
(or vice versa) the /dev/disk stable paths to the disks change, and the guest
might be relying on them.
To provide full flexibility there should be two choices:
- emulated/passthrough ('disk' vs. 'lun')
- if emulated, read-only/read-write
When QEMU adds support, passthrough read-only can be supported too.
--
To view, visit http://gerrit.ovirt.org/30123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic317722be9ef8978b50352c12bc06ea8c906dcd0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Paolo Bonzini <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
