Allon Mureinik has posted comments on this change. Change subject: engine: Edit disk description when VM is up ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/30477/2//COMMIT_MSG Commit Message: Line 13: This patch includes: Line 14: - Fixing the UpdateVmDiskCommand to allow such updates Line 15: - Adding cases to UpdateVmDiskCommandTest to check this functionality Line 16: - Fixing EditDiskModel to allow this update in the UI Line 17: > isn't there any rfe/bz on it? nope. Line 18: Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 http://gerrit.ovirt.org/#/c/30477/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java: Line 339: } Line 340: Line 341: @Test Line 342: public void canDoActionUpdateDescriptionVmDown() { Line 343: canDoActionUpdateWipeAfterDelete(VMStatus.Down); > shouldn't it invoke 'canDoActionUpdateDescription' ? yup - fixed. Line 344: } Line 345: Line 346: @Test Line 347: public void canDoActionUpdateDescriptionVmUp() { Line 344: } Line 345: Line 346: @Test Line 347: public void canDoActionUpdateDescriptionVmUp() { Line 348: canDoActionUpdateWipeAfterDelete(VMStatus.Up); > same yup - fixed. Line 349: } Line 350: Line 351: private void canDoActionUpdateDescription(VMStatus status) { Line 352: DiskImage disk = createDiskImage(); -- To view, visit http://gerrit.ovirt.org/30477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
