Eli Mesika has posted comments on this change. Change subject: core: Add config value to enable to skip fencing if SD is active ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/30193/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1875: /** Line 1876: * Feature to skip fencing if host is connected to at least one storage domain Line 1877: */ Line 1878: @TypeConverterAttribute(Boolean.class) Line 1879: @DefaultValueAttribute("false") IMO this should be defaulted to "true" since it is set for all version below 3.5 to false in the config sql file Line 1880: SkipFencingIfSDActiveSupported, Line 1881: Line 1882: Invalid http://gerrit.ovirt.org/#/c/30193/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 793: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'false', '3.1'); Line 794: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'false', '3.2'); Line 795: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'false', '3.3'); Line 796: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'false', '3.4'); Line 797: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'true', '3.5'); This line is not needed , if version value not found then it is taken from the hard coded default which is true for all version above 3.4 (see my comment on he configvalues default setting) Line 798: Line 799: ------------------------------------------------------------------------------------ Line 800: -- Update with override section Line 801: ------------------------------------------------------------------------------------ -- To view, visit http://gerrit.ovirt.org/30193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9f1e480a5cedb7988eba37701c3db7b3950c010 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
