Ravi Nori has posted comments on this change. Change subject: engine : command infrastructure should know when the "execute" phase finished ......................................................................
Patch Set 3: @Oved Hi Oved, This patch handles the exceptions in the command callback. If there is an exception in onFailed, the exception needs to be handled in CoTor so that onNotified is still updated in the database. If there was an error in doPolling, we mark the command as failed and let onFailed method of call back handle the command. In command base we already catch RuntimeException and VbllException and handle it. I have changed in both exceptions to set the status to FAILED. -- To view, visit http://gerrit.ovirt.org/30281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie36e7d8a0263d5dd90fabe914a76711d5c001e72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
