Ravi Nori has posted comments on this change. Change subject: engine : Command Executor should persist command before submitting to threadpool ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/29219/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 84: case NOT_STARTED: Line 85: coco.retrieveCommand(cmdEntity.getId()).setCommandStatus(CommandStatus.FAILED_RESTARTED); Line 86: break; Line 87: default: Line 88: if (!cmdEntity.isCallBackNotified()) { > why do you differentiate here for other statuses, and not fail the command If the command is an ACTIVE_ASYNC_EXECUTED it means it is already submitted for execution and we should execute doPolling to check if the command has finished. So we cant fail ACTIVE_ASYNC_EXECUTED commands. Line 89: addToCallBackMap(cmdEntity); Line 90: } Line 91: break; Line 92: } Line 121: return executeCommand(command, cmdContext); Line 122: } Line 123: }); Line 124: } catch(RejectedExecutionException ex) { Line 125: command.setCommandStatus(CommandStatus.FAILED); > I think we should consider perform audit log or any other log with anti flo Will do Line 126: } Line 127: return command.getCommandId(); Line 128: } Line 129: -- To view, visit http://gerrit.ovirt.org/29219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d510836dc822a95198dc1db4a4f74206466f0c9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
