Liron Aravot has uploaded a new change for review.

Change subject: core: display correct status on error message
......................................................................

core: display correct status on error message

When a disk isn't on applicable status the displayed status in the CDA
message should be the applicable status and not the current disk status.

Change-Id: I611d2d3c5561c4d40a1c1a19b2844c0fe01ae026
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1114431
Signed-off-by: Liron Aravot <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/63/30563/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
index ca1b57d..80b30e3 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
@@ -233,7 +233,7 @@
         for (DiskImage diskImage : diskImages) {
             if (diskImage.getImageStatus() != applicableStatus) {
                 return new 
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DISK_NOT_IN_APPLICABLE_STATUS,
-                        String.format("$status %s", 
diskImage.getImageStatus().name()));
+                        String.format("$status %s", applicableStatus.name()));
             }
         }
 


-- 
To view, visit http://gerrit.ovirt.org/30563
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I611d2d3c5561c4d40a1c1a19b2844c0fe01ae026
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to