Mike Kolesnik has posted comments on this change. Change subject: core: MacPool related Commands ......................................................................
Patch Set 16: (2 comments) http://gerrit.ovirt.org/#/c/28705/16/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveMacPoolByIdParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveMacPoolByIdParameters.java: Line 4: Line 5: import org.ovirt.engine.core.common.validation.group.UpdateEntity; Line 6: import org.ovirt.engine.core.compat.Guid; Line 7: Line 8: public class RemoveMacPoolByIdParameters extends VdcActionParametersBase { > can I place @NotNull on org.ovirt.engine.core.common.action.IdParameters#i You can (it makes perfect sense for all commands using it) and should do it on a separate patch. Line 9: Line 10: @NotNull(groups = {UpdateEntity.class }) Line 11: private Guid macPoolId; Line 12: http://gerrit.ovirt.org/#/c/28705/16/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java: Line 570: public StoragePoolDAO getStoragePoolDAO() { Line 571: return getDbFacade().getStoragePoolDao(); Line 572: } Line 573: Line 574: public MacPoolDao getMacPoolDao() { > it's used by org.ovirt.engine.core.bll.storage.AddEmptyStoragePoolCommand#a I see. I think then it should be both in MacPoolBaseCommand and in AddEmptyStoragePoolCommand as it's really not something needed for all other commands so no need to have it on such basic ancestors. Alernatively you could use the getDbFacade() that already exists in AuditLogableBase and just get your DAO from there.. Line 575: return getDbFacade().getMacPoolDao(); Line 576: } Line 577: Line 578: public StorageDomainStaticDAO getStorageDomainStaticDAO() { -- To view, visit http://gerrit.ovirt.org/28705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0c3657e3e53699bcafa375befdce848b01a2f3 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
