Alon Bar-Lev has posted comments on this change. Change subject: aaa: more sync fixes ......................................................................
Patch Set 1: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/30589/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 96: List<ExtMap> groups = new ArrayList<>(); Line 97: for (ExtMap memberOf : entity.get(key, Collections.<ExtMap> emptyList())) { Line 98: ExtMap cachedGroup = groupsCache.get(memberOf.get(GroupRecord.ID)); Line 99: constructGroupsMembershipTree(cachedGroup, GroupRecord.GROUPS, groupsCache); Line 100: groups.add(cachedGroup); if we construct the cache entry we can do this one per entry... no? or do you want to clone it? groups.add( constructGroupsMembershipTree( groupsCache.get(memberOf.get(GroupRecord.ID)).clone(), GroupRecord.GROUPS, groupsCache ) ); Line 101: } Line 102: entity.put(key, groups); Line 103: } Line 104: -- To view, visit http://gerrit.ovirt.org/30589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dddcf6b1327f5540e333f7e3d66ef644c40822a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
