Mike Kolesnik has posted comments on this change.
Change subject: core: Code cleanup and adjustment of
UpdateNetworkToVdsInterfaceCommand
......................................................................
Patch Set 3: (1 inline comment)
Basically +2 but consider using @SupressWarnings
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
Line 32: private static final long serialVersionUID = -6287919322257350216L;
IMHO It's better to use @SupressWarnings("serial") instead since the command is
not being serialized, and shouldn't really implement Serializable.
--
To view, visit http://gerrit.ovirt.org/6008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib97a482bc781aedacadbc1227a4ff2031a20995d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
