Yair Zaslavsky has posted comments on this change. Change subject: engine : command infrastructure should know when the "execute" phase finished ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/30281/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2160: } Line 2161: } Line 2162: Line 2163: public void setCommandExecuted() { Line 2164: Transaction transaction = TransactionSupport.suspend(); Ravi, if the thread is not in transaction, suspend() returns null. Is it safe to pass null to resume? Line 2165: try { Line 2166: TaskManagerUtil.updateCommandExecuted(getCommandId()); Line 2167: } finally { Line 2168: TransactionSupport.resume(transaction); -- To view, visit http://gerrit.ovirt.org/30281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie36e7d8a0263d5dd90fabe914a76711d5c001e72 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
