Jason Liao has posted comments on this change. Change subject: engine: NUMA feature transaction support ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28241/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 582: } Line 583: } Line 584: Line 585: protected void addVmNumaNodes() { Line 586: List<VmNumaNode> vmList = DbFacade.getInstance().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(getVmId()); > rename to vmNumaList Done Line 587: if (vmList != null && vmList.size() > 0) { Line 588: List<VmNumaNode> templateList = new ArrayList<>(); Line 589: for (VmNumaNode vnode : vmList) { Line 590: List<Pair<Guid, Pair<Boolean, Integer>>> pairs = vnode.getVdsNumaNodeList(); Line 590: List<Pair<Guid, Pair<Boolean, Integer>>> pairs = vnode.getVdsNumaNodeList(); Line 591: if (pairs != null && pairs.size() > 0) { Line 592: for (Pair<Guid, Pair<Boolean, Integer>> pair : pairs) { Line 593: pair.setFirst(null); Line 594: pair.getSecond().setFirst(false); > why false? the interesting case here is when the vnode is pinned. remove this line Line 595: } Line 596: } Line 597: templateList.add(vnode); Line 598: } -- To view, visit http://gerrit.ovirt.org/28241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84e59fa38c9174fe7150116bf3c8832f7fac1dd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
