Shubhendu Tripathi has posted comments on this change. Change subject: engine: gluster volume geo replication entities ......................................................................
Patch Set 10: (4 comments) http://gerrit.ovirt.org/#/c/29605/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java: Line 7: public class GlusterGeoRepSession extends IVdcQueryable implements BusinessEntityWithStatus<Guid, GeoRepSessionStatus>{ Line 8: Line 9: private static final long serialVersionUID = 1L; Line 10: Line 11: Guid masterVolumeId; default access for the variables ?? Line 12: String sessionKey; Line 13: String slaveNodeHostName; Line 14: Guid slaveNodeUuid; Line 15: String slaveVolumeName; Line 9: private static final long serialVersionUID = 1L; Line 10: Line 11: Guid masterVolumeId; Line 12: String sessionKey; Line 13: String slaveNodeHostName; slaveNodeName ot slaveHostName ??? Line 14: Guid slaveNodeUuid; Line 15: String slaveVolumeName; Line 16: Guid sessionId; Line 17: Guid slaveVolumeId; http://gerrit.ovirt.org/#/c/29605/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java: Line 9: public class GlusterGeoRepSessionDetails implements Serializable{ Line 10: Line 11: private static final long serialVersionUID = -8084667500866439692L; Line 12: Line 13: String sessionKey; Why default access for the variables ?? Line 14: Guid masterBrickId; Line 15: Guid slaveNodeUuid; Line 16: String slaveNodeHostName; Line 17: GeoRepSessionStatus status; Line 12: Line 13: String sessionKey; Line 14: Guid masterBrickId; Line 15: Guid slaveNodeUuid; Line 16: String slaveNodeHostName; slaveNodeName or slaveHostName ?? Line 17: GeoRepSessionStatus status; Line 18: String checkPointStatus; Line 19: GeoRepCrawlStatus crawlStatus; Line 20: Long filesSynced; -- To view, visit http://gerrit.ovirt.org/29605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
