Ravi Nori has posted comments on this change. Change subject: engine : Replace ACTIVE_ASYNC with async flag ......................................................................
Patch Set 4: Ok I think I finally understand the idea. Let me summarize The parent calls executeCommand on CommandExecutor and lets it know if the command is sync/async. The only issue with it is Remove Snapshot is an external command and is async. RemoveSnapshotCommand registers itself with Command Executor by calling persistCommandWithoutContext. I can see adding another variable in there to indicate if it is a sync/async command. But the method signature becomes public void persistCommandWithoutContext(VdcActionType parentCommand, boolean enableCallBack, boolean isAsync) Is that okay? -- To view, visit http://gerrit.ovirt.org/30555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I382790a2f4042f2924a0916f62047790bb6d5e94 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
