Eli Mesika has posted comments on this change. Change subject: aaa: present authz and namespace information ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/30645/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 907: AS Line 908: Line 909: SELECT permissions.id as id, permissions.role_id as role_id, permissions.ad_element_id as ad_element_id, permissions.object_id as object_id, permissions.object_type_id as object_type_id, Line 910: roles.name as role_name, roles.role_type as role_type, roles.allows_viewing_children as allows_viewing_children, roles.app_mode as app_mode, fn_get_entity_name(permissions.object_id,permissions.object_type_id) as object_name, Line 911: (fn_authz_entry_info(permissions.ad_element_id)).name as owner_name, (fn_authz_entry_info(permissions.ad_element_id)).namespace as namespace, (fn_authz_entry_info(permissions.ad_element_id)).authz as authz > although db-wise this is working i'm sure there is a way to optimize this. No need to optimize : This is taken from PG Docs A STABLE function cannot modify the database and is guaranteed to return the same results given the same arguments for all rows within a single statement. This category allows the optimizer to optimize multiple calls of the function to a single call. So, since fn_authz_entry_info was declared as STABLE , teh result is cashed and will be used for subsequent calls implicitly See http://www.postgresql.org/docs/8.3/static/xfunc-volatility.html Line 912: FROM permissions INNER JOIN Line 913: roles ON permissions.role_id = roles.id; Line 914: Line 915: CREATE OR REPLACE VIEW internal_permissions_view -- To view, visit http://gerrit.ovirt.org/30645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b2bc84364b8ac7ee180848a66bd03489b03e4d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
