Omer Frenkel has posted comments on this change. Change subject: engine: Throw canDo on addVmCommand if template is not in cluster ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30638/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 1327: getParameters().getVmStaticData().setDefaultDisplayType(defaultDisplayType); Line 1328: } Line 1329: } Line 1330: Line 1331: protected boolean isValidTemplate() { > Why? It validates the template and the error message related to the templat but it validate only the template dc, not everything, like if its null, disabled and more, you can suggest something else, but i think the current name is too general and does not describe well the content of the method Line 1332: return getVmTemplate().getStoragePoolId().equals(getStoragePoolId()); Line 1333: } Line 1334: -- To view, visit http://gerrit.ovirt.org/30638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2566b18049bf7603700572dc5d419a640f294ada Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
