anmolbabu has posted comments on this change. Change subject: engine : Bll Query to get geo-rep status details ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/30528/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepStatusDetailQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepStatusDetailQuery.java: Line 14: Line 15: @Override Line 16: protected void executeQueryCommand() { Line 17: GlusterVolumeGeoRepStatusDetailsPrameters parameters = getParameters(); Line 18: VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GetGlusterVolumeGeoRepStatusDetail, new GlusterVolumeGeoRepSessionDetailsVDSParameters(getUpServerId(parameters.getClusterId()), getGlusterVolumeName(parameters.getVolumeId()), parameters.getSlaveHost(), parameters.getSlaveVolumeName())); > I think the detail information should come from database, no? I thought the sync job would do gluster volume geo-replication MASTER status and provide an over view of all sessions of a particular (selected) volume So,if the user wants to see the geo rep details per session(master-slave transaction) I thought the detail command would be invoked on user demand. Ok I'll change this Line 19: getQueryReturnValue().setReturnValue((GlusterVolumeGeoRepStatusDetailForXmlRpc) returnValue.getReturnValue()); Line 20: } -- To view, visit http://gerrit.ovirt.org/30528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If13b945fb21e36e4614bb95393aba71e57dba9be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
