Xiaolei Shi has posted comments on this change. Change subject: core: need vds id when build vm numa properties ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/27830/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java: Line 13: import org.ovirt.engine.core.common.businessentities.VmNumaNode; Line 14: import org.ovirt.engine.core.utils.NumaUtils; Line 15: Line 16: public class NumaSettingFactory { Line 17: private static NumaSettingFactory instance; > I think there is no state you save here so the Singleton pattern is redunda Done Line 18: Line 19: static { Line 20: instance = new NumaSettingFactory(); Line 21: } -- To view, visit http://gerrit.ovirt.org/27830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19be54812d0ebbb54145f33e6b036af84ff1d8ae Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
