Yair Zaslavsky has posted comments on this change. Change subject: engine : Remove ACTIVE_ASYNC status ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/30555/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2106: getReturnValue().getCanDoActionMessages().addAll(internalReturnValue.getCanDoActionMessages()); Line 2107: getReturnValue().setCanDoAction(internalReturnValue.getCanDoAction()); Line 2108: } Line 2109: Line 2110: public void persistCommand(VdcActionType parentCommand, boolean enableCallBack) { Not sure this has to do with this patch... can we split to two patches? have a patch that changes persistCommand, and have the patch that removes the state? Line 2111: persistCommand(parentCommand, getContext(), enableCallBack); Line 2112: } Line 2113: Line 2114: public void persistCommand(VdcActionType parentCommand, CommandContext cmdContext, boolean enableCallBack) { -- To view, visit http://gerrit.ovirt.org/30555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I382790a2f4042f2924a0916f62047790bb6d5e94 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
