Allon Mureinik has posted comments on this change. Change subject: core: WAD should be Ignored on File Domain Disks ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30706/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java: Line 127: params.setVolumeFormat(diskImage.getVolumeFormat()); Line 128: params.setVolumeType(diskImage.getVolumeType()); Line 129: params.setUseCopyCollapse(true); Line 130: params.setSourceDomainId(srcStorageDomainId); Line 131: setStorageDomainId(srcStorageDomainId); > Yikes! Regardless - you're COPYING a disk. WAD should be calculated according to the destination type - just use diskImage.getStorageTypes.get(0). Just make sure it's initialized properly by the command :-) Line 132: params.setWipeAfterDelete(ImagesHandler.shouldWipeAfterDelete( Line 133: diskImage.isWipeAfterDelete(), getStorageDomain().getStorageType())); Line 134: params.setEntityInfo(new EntityInfo(VdcObjectType.VM, getVmId())); Line 135: params.setParentParameters(getParameters()); -- To view, visit http://gerrit.ovirt.org/30706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8a9932725ef861525f5102e8617938f0e0a71c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
