Alona Kaplan has posted comments on this change. Change subject: webadmin: Use "dry run" to validate NIC label ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/30581/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java: Line 225: if (drop || !candidate.equals(currentCandidate) || !equals(op1, currentOp1) || !equals(op2, currentOp2)) { Line 226: currentCandidate = candidate; Line 227: currentOp1 = op1; Line 228: currentOp2 = op2; Line 229: getOperationCandidateEvent().raise(this, new OperationCadidateEventArgs(candidate, op1, op2, drop, dryRun)); I think that the event shouldn't be fired in case of a dry run. Line 230: } Line 231: return !candidate.isNullOperation(); Line 232: } Line 233: http://gerrit.ovirt.org/#/c/30581/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/OperationCadidateEventArgs.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/OperationCadidateEventArgs.java: Line 14: private final NetworkItemModel<?> op2; Line 15: Line 16: private final boolean drop; Line 17: Line 18: private final boolean dryRun; If you fix what I wrote in the HostSetupNetworksModel, the changes in this class can be removed. Line 19: Line 20: public OperationCadidateEventArgs(NetworkOperation candidate, Line 21: NetworkItemModel<?> op1, Line 22: NetworkItemModel<?> op2, http://gerrit.ovirt.org/#/c/30581/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java: Line 149: NetworkOperation candidate = evtArgs.getCandidate(); Line 150: NetworkItemModel<?> op1 = evtArgs.getOp1(); Line 151: NetworkItemModel<?> op2 = evtArgs.getOp2(); Line 152: Line 153: if (evtArgs.isDryRun()) { If you fix what I wrote in the HostSetupNetworksModel, this code can be removed. Line 154: return; Line 155: } Line 156: Line 157: if (candidate == null) { -- To view, visit http://gerrit.ovirt.org/30581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic110c6dd4198a03c3274dfbb9fe39a8687a9861a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
