Martin Peřina has posted comments on this change. Change subject: core: Add fencing policy as parameter to fenceNode VDSM verb ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30584/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java: Line 79: Line 80: // load cluster fencing policy Line 81: FencingPolicy fencingPolicy = getDbFacade().getVdsGroupDao().get( Line 82: getVds().getVdsGroupId() Line 83: ).getFencingPolicy(); > It will never be null, right? If I didn't make any mistake, fencing policy should never be null. Line 84: getParameters().setFencingPolicy(fencingPolicy); Line 85: Line 86: // Make sure that the StopVdsCommand that runs by the RestartVds Line 87: // don't write over our job, and disrupt marking the job status correctly -- To view, visit http://gerrit.ovirt.org/30584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61ca142f0630ec2d8c1ec16e44c01af989c19079 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
