Liron Aravot has posted comments on this change. Change subject: core: attach device ioTune map ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29816/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 365: Guid diskProfileId = diskImage.getDiskProfileId(); Line 366: if (diskProfileId == null) { Line 367: return null; Line 368: } Line 369: StorageQos storageQos = diskProfileStorageQosMap.get(diskProfileId); > - perhaps my last comment on that was bit misspelled. the values in the map - forgot to mention, when you put in the map you should put the built ioTune twice, one with the profile id and once with the qos id as the key. that way even if we have different profile defined with the same qos, we'll not build the iotune map again. diskProfileStorageQosMap.put(diskProfileId, ioTune); diskProfileStorageQosMap.put(qosId, ioTune); now get will work for both. Line 370: if (storageQos == null) { Line 371: storageQos = DbFacade.getInstance().getStorageQosDao().GetQosByDiskProfileId(diskProfileId); Line 372: if (storageQos == null) { Line 373: return null; -- To view, visit http://gerrit.ovirt.org/29816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I515caa7ff8996711610a77a57d6683d2655545de Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
