Tomas Jelinek has posted comments on this change. Change subject: webadmin: auto select dialog tab ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27781/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 2618: // Minimum 'Physical Memory Guaranteed' is 1MB Line 2619: validateMemorySize(getMemSize(), Integer.MAX_VALUE, 1); Line 2620: if (!(getBehavior() instanceof TemplateVmModelBehavior) && getMemSize().getIsValid()) { Line 2621: validateMemorySize(getMinAllocatedMemory(), getMemSize().getEntity(), 1); Line 2622: } > Can you outline the steps needed to make this happen so I can make sure it when you create or edit an instance type (because the instance type contains only the HW part of the VM, only this method is called). You can find it in the Configure -> Instance Types Line 2623: Line 2624: return behaviorValid && customPropertySheetValid && getName().getIsValid() && getDescription().getIsValid() Line 2625: && getMinAllocatedMemory().getIsValid() Line 2626: && getNumOfMonitors().getIsValid() && getUsbPolicy().getIsValid() -- To view, visit http://gerrit.ovirt.org/27781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9c5ad0cd3ee7f54606958b1fc8abd2bbd972ed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
