Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in RemoveImageCommand and anscentors
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 81: protected DiskImageDynamicDAO getDiskImageDynamicDAO() {
CreateTempalteCommand is full of DbFacade.getInstance().geXXXDAO() - not sure
what you mean in "the new method" - please explain
Line 363:
the point of making it a helper method was to use the same DAO as the rest of
the class, so it can be tested/injected
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 39: protected void initDiskImage() {
So it can be overriden in tests - this is the main point of these methods.
Line 42:
not true - you want this block to happen if the ID passed is null or Guid.Empty.
if it's indeed null, you'll be running Empty.equals(null) which evaluates to
null.
I do agree that's this is disgusting, though - I'll extract a util to GuidUtils.
--
To view, visit http://gerrit.ovirt.org/6024
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66b450571d680e556dc812d9926161d9f190221
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
