Maor Lipchuk has posted comments on this change. Change subject: core: Add test for import unregistered VM ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/29795/6/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java: Line 40: public class ImportVMFromConfigurationCommandTest { Line 41: private static Guid vmId; Line 42: private static Guid storageDomainId; Line 43: private static Guid storagePoolId; Line 44: private static Guid clusterId; > If you're initializing them per test, they should not be static. if they will not be static we will not be able to use them in the private static method at createParametersWhenImagesExistOnTargetStorageDomain.... Line 45: private static final String VM_OVF_XML_DATA = "src/test/resources/vmOvfData.xml"; Line 46: private String xmlOvfData; Line 47: private VDSGroup vdsGroup; Line 48: -- To view, visit http://gerrit.ovirt.org/29795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f68a66da4de6b9dbfb664d3678b25582a82496 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
