Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: IE9 header value
......................................................................
Patch Set 1:
Before giving any score, I'd like to suggest some things to consider:
* one more place where the fix could be applied -
RestApiSessionManager#acquireSession method (extracting REST API session ID
value)
* instead of applying the fix inline, we could introduce some util class to
better isolate the fix for IE9 quirk
For example:
package org.ovirt.engine.ui.common.utils;
public class HttpUtils {
// IE9 "empty string on missing header" fix isolated to this method
// If allowBlank == true, method may return empty string; otherwise return
null
public static String getHeader(Response response, boolean allowBlank) { ... }
// shortcut for allowBlank == false
public static String getHeader(Response response) {
return getHeader(response, false);
}
}
Code in BaseSystemModule + RestApiSessionManager could use above-mentioned util
class.
--
To view, visit http://gerrit.ovirt.org/30768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4144a585a1dec1e736d30f7b7b698687543f7936
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
