Ravi Nori has posted comments on this change. Change subject: engine, webadmin: Webadmin read reports.xml from remote reports app ......................................................................
Patch Set 21: (4 comments) http://gerrit.ovirt.org/#/c/29723/21/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRedirectServletReportsPageQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRedirectServletReportsPageQuery.java: > why do we need it? it is in the namespace of the engine's services The front end needs to know the base url to be used for reports web app. Base on the base url the frontend build other urls to access the reports by settings the url in a FormPanel please see org.ovirt.engine.ui.webadmin.widget.form.PostableFrame.java So this query is performed from frontend to get the reports base url Line 1: package org.ovirt.engine.core.bll; Line 2: Line 3: import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; Line 4: import org.ovirt.engine.core.utils.EngineLocalConfig; http://gerrit.ovirt.org/#/c/29723/21/backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml File backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml: Line 56 Line 57 Line 58 Line 59 Line 60 > why do we keep ReportsRedirectServlet? Will delete http://gerrit.ovirt.org/#/c/29723/21/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java: Line 46: setIsTimerDisabled(true); Line 47: } Line 48: Line 49: public void setBaseUrl(String baseUrl) { Line 50: reportUrl = baseUrl + "/flow.html" + "?viewAsDashboardFrame=true"; //$NON-NLS-1$ //$NON-NLS-2$ > what is that? why can't we get it out of the interface? I dont understand your question Alon. This is in the frontend to build the url for reports web app to be displayed in a frame Line 51: } Line 52: Line 53: public Map<String, List<String>> getParams() { Line 54: return htmlParams.getParameters(); http://gerrit.ovirt.org/#/c/29723/21/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 213 Line 214 Line 215 Line 216 Line 217 > why do we need the above? Will remove -- To view, visit http://gerrit.ovirt.org/29723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
