Maor Lipchuk has posted comments on this change.
Change subject: core:Replace vm id with number of vms in views.
......................................................................
Patch Set 3: (7 inline comments)
The field number_of_vms is fetched instead of vm_id, both of the fields were
fetched from separate views, so I don't think there should be performance
regressions regarding this.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java
Line 76: if (diskImage != null) {
I'm not sure I'm following, there is already:
DbFacade.getInstance().getImageStorageDomainMapDao().remove(diskImage.getImageId
());
Come to think about it, maybe it's worth change all the diskImage.getImageId to
template.getImageId just to keep it uniform?
Line 79: .getVmDeviceDAO()
Why use null? template should have only one image.
Isn't it suppose to have the same outcome?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 146: Map<Boolean, VmTemplate> templateMap =
will change the comment to
// disk image is the only disk type that can be part of the template disks
Line 150: if (!templateMap.values().isEmpty()) {
Done
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
Line 21: private VmEntityType vmEntityType;
Agreed, will change
Line 49: setNumberOfVms(numberOfVms);
Done
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IImage.java
Line 20
Why not related? the container id should be removed with the vm id.
--
To view, visit http://gerrit.ovirt.org/5216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
