Maor Lipchuk has posted comments on this change. Change subject: core: Use validation only if Template is not blank ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/30888/1//COMMIT_MSG Commit Message: Line 13: Blank Template is the default Template for every new created VM, and it is Line 14: hosted on the default Data Center Line 15: Line 16: Change-Id: I06a0c911c50f6ff25d9dca358c6a199fa0cdbb59 Line 17: Signed-off-by: Maor Lipchuk <[email protected]> > please add bug url https://bugzilla.redhat.com/show_bug.cgi?id=1125196 done http://gerrit.ovirt.org/#/c/30888/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 453: if (getVmTemplate().isDisabled()) { Line 454: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_IS_DISABLED); Line 455: } Line 456: Line 457: if (!getVmTemplateId().equals(Guid.Empty) && !isTemplateInValidDc()) { > i think its better to put this logic inside the method done Line 458: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_NOT_EXISTS_IN_CURRENT_DC); Line 459: } Line 460: Line 461: // A VM cannot be added in a cluster without a defined architecture -- To view, visit http://gerrit.ovirt.org/30888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a0c911c50f6ff25d9dca358c6a199fa0cdbb59 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
