Allon Mureinik has posted comments on this change.

Change subject: core: Make default storage format V3
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/30916/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java:

Line 52:     public StorageDomainStatic() {
Line 53:         id = Guid.Empty;
Line 54:         storageType = StorageDomainType.Master;
Line 55:         storagePoolType = StorageType.UNKNOWN;
Line 56:         storageFormat = StorageFormatType.V3;
> Just to be extra-sure, this should be affecting data domains only (it may b
This currently effects all domains - we upgrade ISO and export domains to V3 
too, and I don't really want to add any distinction here.

Do you think this would be problem?
Line 57:         autoRecoverable = true;
Line 58:         name = "";
Line 59:     }
Line 60: 


-- 
To view, visit http://gerrit.ovirt.org/30916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c4241ae94fbe32d54657b778dbf8b39116dc3b4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to