Tal Nisan has posted comments on this change. Change subject: core: Add audit log when removing networks from iSCSI bond. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/30988/1//COMMIT_MSG Commit Message: Line 10: from the iSCSI bond, will only take affect, after the Hosts will be moved Line 11: to maintenance and activated again. Line 12: Line 13: Change-Id: I087818bb48cc9243e76b2cb850e6262104537f3c Line 14: Bug-Url: https://bugzilla.redhat.com/BZ1094144 Remove the "BZ", it's unrelated to the link http://gerrit.ovirt.org/#/c/30988/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java: Line 80: setSucceeded(true); Line 81: } Line 82: Line 83: private void addAuditLogForRemovedNetowrks(Set<Guid> removedNetworks) { Line 84: List<String> networkrNames = new ArrayList<>(); s/networkrName/networkNames Line 85: for (Guid networkId : removedNetworks) { Line 86: Network network = getDbFacade().getNetworkDao().get(networkId); Line 87: networkrNames.add(network.getName()); Line 88: } -- To view, visit http://gerrit.ovirt.org/30988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I087818bb48cc9243e76b2cb850e6262104537f3c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
