Martin Mucha has posted comments on this change. Change subject: core: Removal of labelled network from DC inconsistent with removal from cluster ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30795/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java: Line 139: Backend.getInstance().runInternalMultipleActions(VdcActionType.PersistentSetupNetworks, parameters, context); Line 140: } Line 141: } Line 142: Line 143: public static boolean shouldNetworkBeRemovedFromHosts(Network persistedNetwork, Version compatibilityVersion) { > Sorry, but after rethinking it, I don't think it is a good name:) used: "shouldRemoveNetworkFromHostUponNetworkRemoval" Line 144: return !persistedNetwork.isExternal() && NetworkUtils.isLabeled(persistedNetwork) Line 145: && setupNetworkSupported(compatibilityVersion); Line 146: } -- To view, visit http://gerrit.ovirt.org/30795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ebc162324ff2ed98374d6a9a3bd9d87bb69db3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
