Alona Kaplan has posted comments on this change. Change subject: webadmin: Validate no duplicate network names on import ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30650/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java: Line 212: if (!valid) { Line 213: Frontend.getInstance() Line 214: .getFrontendFailureEvent() Line 215: .raise(this, Line 216: new FrontendFailureEventArgs(Collections.singletonList(new Message(ConstantsManager.getInstance() > Not worth the effort in my opinion, when it comes to rendering these cells. Please consult Eldan. Maybe he"ll have another idea how to represent the error in the dialog. Or maybe he will be ok with your solution... Line 217: .getMessages() Line 218: .duplicateNetworkNamesOnImport(StringUtils.join(duplicateNames, ", ")))))); //$NON-NLS-1$ Line 219: } Line 220: -- To view, visit http://gerrit.ovirt.org/30650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If63d450bfc8d666ebb383e29fdfe43fcf879db78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
