Liron Aravot has posted comments on this change. Change subject: engine : placeholders of child commands aren't cleared on exception ......................................................................
Patch Set 1: Code-Review-1 I haven't reviewed the code here, but i'm pretty sure that it's not the solution for the attached bug but to other bug. The provided solution is for commands with missing ctor (i think that ogofen opened a bug for that, please talk to him). The bug in the commit message is different, to reproduce it you can create a template from vm with few disk and simulate failure in the execution of the first child command (not all placeholders will be cleared). -- To view, visit http://gerrit.ovirt.org/31037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I457a1f9357fda9232a8757984d6936d9c977aa62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
