Martin Peřina has posted comments on this change. Change subject: core: Add fencing policy as parameter to fenceNode VDSM verb ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/30584/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java: Line 44: */ Line 45: @NonTransactiveCommandAttribute Line 46: public class RestartVdsCommand<T extends FenceVdsActionParameters> extends FenceVdsBaseCommand<T> { Line 47: Line 48: private boolean skippedDueToFencingPolicy; > why not to initialize it here to false? Personally I prefer to do all initialization inside constructors. Line 49: Line 50: protected List<VM> getVmList() { Line 51: return mVmList; Line 52: } -- To view, visit http://gerrit.ovirt.org/30584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61ca142f0630ec2d8c1ec16e44c01af989c19079 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
