Maor Lipchuk has uploaded a new change for review. Change subject: core: Add Charset when converting to byte to String ......................................................................
core: Add Charset when converting to byte to String Fix a findbug issue, by adding a charset when converting byte array to String. Change-Id: I14a1253c24d4a01382743b9388a5d8474915256c Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/31059/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java index d2f06d7..d7f1a7c 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java @@ -7,6 +7,7 @@ import static org.ovirt.engine.core.utils.MockConfigRule.mockConfig; import java.io.IOException; +import java.nio.charset.Charset; import java.nio.file.Files; import java.nio.file.Paths; import java.util.Arrays; @@ -78,7 +79,7 @@ } private void setXmlOvfData() throws IOException { - xmlOvfData = new String(Files.readAllBytes(Paths.get(VM_OVF_XML_DATA))); + xmlOvfData = new String(Files.readAllBytes(Paths.get(VM_OVF_XML_DATA)), Charset.forName("UTF-8")); } @Test -- To view, visit http://gerrit.ovirt.org/31059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I14a1253c24d4a01382743b9388a5d8474915256c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
