Michael Kublin has posted comments on this change. Change subject: core: Prepare RemoveSnapshotCommand for testing ......................................................................
Patch Set 3: (5 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java Line 127: also , these is idea to continue to perform a canDoAction test, even if we failed at first time? I think these is a good idea if you already re factoring a code also fix a errors there Line 163: IMHO, such style of coding is a try to hide some ugly method, but it is still there. Line 177: maybe instead of creating such class just make all his methods static? Line 206: maybe these also can be moved to parrent .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java Line 518: If u added a method to parent class, please remove the similar method from child classes -- To view, visit http://gerrit.ovirt.org/6118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e935b4324bba1b0cd2b501bfcd8738f1302cea1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
