Omer Frenkel has posted comments on this change.
Change subject: core: clear disk device address when it's being unplugged from
a vm
......................................................................
Patch Set 1:
(2 comments)
what about regular ('cold') unplug?
http://gerrit.ovirt.org/#/c/31008/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java:
Line 14: super(parameters);
Line 15:
Line 16: }
Line 17:
Line 18: protected void updateDeviceProperties() {
missing @Override
Line 19: oldVmDevice.setIsPlugged(false);
Line 20: oldVmDevice.setAddress("");
Line 21: getVmDeviceDao().update(oldVmDevice);
Line 22: }
http://gerrit.ovirt.org/#/c/31008/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java:
Line 112
Line 113
Line 114
Line 115
Line 116
this stored procedure doesn't exist? or it should be removed from the sql file
as well?
--
To view, visit http://gerrit.ovirt.org/31008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If82c8983089916ab1c58dd0330442c3aff8d6d02
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
