Lior Vernia has posted comments on this change. Change subject: core: error fix: right bound of range interval should be inclusive. ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29592/2//COMMIT_MSG Commit Message: Line 10: system complaining about no available mac, when Line 11: same start mac and end mac was used. This is not ok, since validations Line 12: allows use of same start mac and end mac for given mac range. Line 13: Line 14: Change-Id: Ifa59366dd400d3b36236c7a7ad83d3f3767b53a4 Please open a bug and add a bug URL here, so this can be backported to the 3.5 stable branch. http://gerrit.ovirt.org/#/c/29592/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/Range.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/Range.java: Line 19: public Range(long rangeStart, long rangeEnd) { Line 20: this.rangeStart = rangeStart; Line 21: this.rangeEnd = rangeEnd; Line 22: Line 23: int numberOfMacs = (int) (rangeEnd - rangeStart) +1; Not a big deal, but a space character between '+' and '1' would be more standard. Line 24: this.availableMacsCount = numberOfMacs; Line 25: this.usedMacs = new BitSet(numberOfMacs); Line 26: } Line 27: -- To view, visit http://gerrit.ovirt.org/29592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa59366dd400d3b36236c7a7ad83d3f3767b53a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
