Alona Kaplan has posted comments on this change. Change subject: webadmin: Reset status panel on redraw ......................................................................
Patch Set 2: As we discussed just summarizing the problems that came up- 1. Menu operations don't update the status panel. 2. Since successful label attachment to a nic doesn't provide any error. If there is a warning in the status bar it will remain. 3. There is no benefit to 'keepStatusText' functionality introduced in the view. It just causes the bug in point 2. 4. Is there any scenario we want to get the 'drag to make changes' message after the initial one was overridden? If no, there is no need for the view to set it (init the status panel) upon each redraw (nicsChangedEvent). Another problem not directly related to this patch- Adding label to nic (not bond) with 'out-of-sync' and I guess also 'unmanaged' networks provides the following error- "Cannot perform bond operation with an out-of-sync network. You could detach net4 first." -- To view, visit http://gerrit.ovirt.org/30581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic110c6dd4198a03c3274dfbb9fe39a8687a9861a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
