Liron Aravot has posted comments on this change. Change subject: core: Calculate storage format when adding an SD ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/30960/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java: Line 167: if (sp != null) { Line 168: sd.setStorageFormat(VersionStorageFormatUtil.getPreferredForVersion( Line 169: sp.getcompatibility_version(), sd.getStorageType()) Line 170: ); Line 171: } else { we missed something on the last patchset, with the current code if getTargetStoragePool() return null we will fail on CDA on isStorageFormatSupportedByStoragePool() so there's might be no point in having else clause at all here. there's something else which is awkward here, let's close that f2f and update in here. Line 172: if (sd.getStorageType().isBlockDomain()) { Line 173: sd.setStorageFormat(StorageFormatType.V2); Line 174: } else { Line 175: sd.setStorageFormat(StorageFormatType.V1); -- To view, visit http://gerrit.ovirt.org/30960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
