Allon Mureinik has posted comments on this change.
Change subject: core: retrieve active Hosts in DC using stored procedure and
not search language
......................................................................
Patch Set 2: (2 inline comments)
see inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 88: if (getVds() == null) {
don't like this block, it's unreadable.
why not try the follwoing:
if (runningVDSs.isEmpty) {
returnValue = false;
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_VDS_IN_POOL);
}
else {
setVds(runningVdss);
}
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolStatusHandler.java
Line 89: if
(DbFacade.getInstance().getVdsDAO().getActiveVdsByPoolId(pool.getId()).size() >
0) {
use getVdsDAO() instead of DbFacade.getInstance.getVdsDAO
--
To view, visit http://gerrit.ovirt.org/6145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3704dd900b3ed2c23a4dae307eb4f23a4d73df2f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
