Gilad Chaplik has posted comments on this change. Change subject: engine:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal ......................................................................
Patch Set 3: (1 comment) looks a lot better! thanks Juan! http://gerrit.ovirt.org/#/c/26381/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java: Line 125: JsonNode hosts = tree.get(HEADER_HOSTS); Line 126: if (hosts != null) { Line 127: for (JsonNode host : hosts) { Line 128: String name = host.get(HEADER_HOST_NAME).asText(); Line 129: String level = host.get(HEADER_RESULT).asText(); possible NPE? what happens if HEADER_HOST_NAME or HEADER_RESULT aren't in the document? Line 130: AttestationValue value = new AttestationValue(); Line 131: value.setHostName(name); Line 132: value.setTrustLevel(AttestationResultEnum.valueOf(level.toUpperCase())); Line 133: values.add(value); -- To view, visit http://gerrit.ovirt.org/26381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f541b004ba383a3098cf7fbfca7a000b11b750f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Emily Zhang <[email protected]> Gerrit-Reviewer: Dave Chen <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Emily Zhang <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
