Daniel Erez has posted comments on this change. Change subject: db, core, webadmin: Add is_live_merge_supported flag ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/30773/4/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 178: ACTION_TYPE_FAILED_VM_IS_NOT_RUNNING=Cannot ${action} ${type}. VM is not running. Line 179: ACTION_TYPE_FAILED_VM_IS_NOT_UP=Cannot ${action} ${type}. VM is not up. Line 180: ACTION_TYPE_FAILED_VM_IS_NOT_DOWN=Cannot ${action} ${type}. At least one of the VMs is not down. Line 181: ACTION_TYPE_FAILED_VM_IS_NOT_DOWN_OR_UP=Cannot ${action} ${type}. VM ${VmName} must be in status Down, Up or Paused. Line 182: ACTION_TYPE_FAILED_VM_HOST_CANNOT_LIVE_MERGE=Cannot ${action} ${type}. The host running VM ${VmName} is not capable of live merging snapshots. please add also to: ./frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 183: ACTION_TYPE_FAILED_VM_IS_SAVING_RESTORING=Cannot ${action} ${type}. VM is in saving/restoring state.\n\ Line 184: -Please try again when the VM is either up or down. Line 185: ACTION_TYPE_FAILED_VM_IS_DURING_SNAPSHOT=Cannot ${action} ${type}. The VM is performing an operation on a Snapshot. Please wait for the operation to finish, and try again. Line 186: ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL=Cannot ${action} ${type} because the VM is in ${vmStatus} status. http://gerrit.ovirt.org/#/c/30773/4/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 462: Line 463: @DefaultStringValue("Cannot ${action} ${type}. VM ${VmName} must be in status Down, Up or Paused.") Line 464: String ACTION_TYPE_FAILED_VM_IS_NOT_DOWN_OR_UP(); Line 465: Line 466: @DefaultStringValue("Cannot ${action} ${type}. The host running VM ${VmName} is not capable of live merging snapshots.") consider adding host name as well if not too cumbersome Line 467: String ACTION_TYPE_FAILED_VM_HOST_CANNOT_LIVE_MERGE(); Line 468: Line 469: @DefaultStringValue("Cannot ${action} ${type}. VM is in saving/restoring state.\n-Please try again when the VM is either up or down.") Line 470: String ACTION_TYPE_FAILED_VM_IS_SAVING_RESTORING(); http://gerrit.ovirt.org/#/c/30773/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java: Line 785: Line 786: AsyncQuery query = new AsyncQuery(this, new INewAsyncCallback() { Line 787: @Override Line 788: public void onSuccess(Object model, Object returnValue) { Line 789: VmSnapshotListModel target = (VmSnapshotListModel) model; just for readability/consistency: s/target/vmSnapshotListModel Line 790: VDS vds = (VDS) returnValue; Line 791: target.setLiveMergeSupported(vds.getLiveMergeSupport()); Line 792: } Line 793: }); -- To view, visit http://gerrit.ovirt.org/30773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I932a74f4010b8b256f8c0cd27a2279b9d83efbb9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
