anmolbabu has posted comments on this change. Change subject: webadmin : Optimise for virt store on volumes ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31041/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 843: list.add(new GlusterVolumeOptionParameters(getOption(volumeId, "group", optionGroupVirt)));//$NON-NLS-1$ Line 844: Line 845: list.add(new GlusterVolumeOptionParameters(getOption(volumeId, "storage.owner-uid", optionOwnerUserVirt)));//$NON-NLS-1$ Line 846: Line 847: list.add(new GlusterVolumeOptionParameters(getOption(volumeId, "storage.owner-gid", optionOwnerGroupVirt)));//$NON-NLS-1$ > I initially thought of this but some how missed it.I'll change it.Thanks :) I'll move the contents of getOptionsForOptimiseForVirtStore to here itself bcoz, I find that this function itself is serving the purpose of setting some options based on the values obtained from the nested set of queries here. Line 848: Line 849: for(GlusterVolumeOptionEntity option : getOptionsForOptimiseForVirtStore(volumeId)) { Line 850: if(!isOptionEnabledOnVolume(volume, option)) { Line 851: list.add(new GlusterVolumeOptionParameters(option)); -- To view, visit http://gerrit.ovirt.org/31041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
