Sandro Bonazzola has posted comments on this change. Change subject: engine: Corrected ownership of the directories ......................................................................
Patch Set 1: Code-Review-1 (1 comment) > IIRC these directories were deliberately left out from the RPMs because they > contain subdirectories from multiple different packages. E.g. > /usr/share/ovirt-engine/firewalld/ contains stuff both from the engine itself > and from Reports. No, in this case it was just to avoid listing all of them. But the tool is right, if a package own /base and /base/middle/leave, it should also own /base/middle. Please keep %dir list sorted http://gerrit.ovirt.org/#/c/31136/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 944: %dir %{engine_data}/setup Line 945: %dir %{engine_data}/setup/plugins Line 946: %dir %{engine_data}/setup/plugins/ovirt-engine-common Line 947: %dir %{engine_data}/setup/plugins/ovirt-engine-remove Line 948: %dir %{engine_data}/setup/plugins/ovirt-engine-setup > Do we need to specify each sub-directory separately? Any other alternative? No other alternative. Please keep this section sorted. Line 949: %dir %{engine_data}/setup/bin/ Line 950: %dir %{engine_log}/setup Line 951: %dir %{engine_data}/setup/ovirt_engine_setup Line 952: %{_bindir}/engine-cleanup -- To view, visit http://gerrit.ovirt.org/31136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I946b446a908e4189e30fe60946e7946e4be384f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
