Martin Mucha has uploaded a new change for review. Change subject: core: coverity issue fix. ......................................................................
core: coverity issue fix. coverity issue wasn't probably solved by inlining method which hypotheticaly returns null. CID 1230092 Although this cannot happen, code was altered in more precise way, so it should be obvious for coverity, that this is not a problem. Change-Id: Id8a06231c6151530ff6c0fee9614b45f39c3a1dd Signed-off-by: Martin Mucha <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/31206/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java index fcd90ca..2e7eed3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java @@ -64,7 +64,15 @@ final List<Long> result = new ArrayList<>(numberOfMacs); int remainingMacs = numberOfMacs; while (remainingMacs > 0) { - final List<Long> allocatedMacs = getRangeWithAvailableMac().allocateMacs(remainingMacs); + + /*this is not needed, rangeWithAvailableMac won't be null, unless there's an error for which NPE should be + thrown, but Coverity detects dereferencing hypothetical null as a problem.*/ + final Range rangeWithAvailableMac = getRangeWithAvailableMac(); + if (rangeWithAvailableMac == null) { + continue; + } + + final List<Long> allocatedMacs = rangeWithAvailableMac.allocateMacs(remainingMacs); remainingMacs -= allocatedMacs.size(); result.addAll(allocatedMacs); -- To view, visit http://gerrit.ovirt.org/31206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8a06231c6151530ff6c0fee9614b45f39c3a1dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
