Juan Hernandez has posted comments on this change.
Change subject: core: Fixing CompositePasswordValueHelper
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
Line 102: if (StringUtils.isNotBlank(value) &&
value.equals(INTERACTIVE_MODE)) {
If you use "equalsIgnoreCase" here it makes it more user friendly.
--
To view, visit http://gerrit.ovirt.org/6191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia75fb5e5a21f24ef87bf2c940d5f95d6e64c4f0a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
