Hello Liron Aravot,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/31273
to review the following change.
Change subject: core: renaming connectAllHostsToPool
......................................................................
core: renaming connectAllHostsToPool
connectAllHostsToPool actually connects the hosts to the related domain
storage server, therefore in this patch its name was changed to
connectHostsInUpToDomainStorageServer.
Change-Id: I15b3cfc6f4a08350b16f252df2587bd2c7737ebe
Related-To-Bug-Url: https://bugzilla.redhat.com/1115845
Signed-off-by: Liron Aravot <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
6 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/31273/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
index 150f633..4a206f0 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
@@ -95,7 +95,7 @@
freeLock();
log.infoFormat("ActivateStorage Domain. Before Connect all hosts to
pool. Time:{0}", new Date());
- connectAllHostsToPool();
+ connectHostsInUpToDomainStorageServer();
runVdsCommand(VDSCommandType.ActivateStorageDomain,
new
ActivateStorageDomainVDSCommandParameters(getStoragePool().getId(),
getStorageDomain().getId()));
log.infoFormat("ActivateStorage Domain. After Connect all hosts to
pool. Time:{0}", new Date());
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
index 3a6cc4d..2e3c33b 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
@@ -104,7 +104,7 @@
return null;
}
});
- connectAllHostsToPool();
+ connectHostsInUpToDomainStorageServer();
// Forcibly detach only data storage domains.
if (getStorageDomain().getStorageDomainType() ==
StorageDomainType.Data) {
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java
index fd49871..28a68cb 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java
@@ -23,7 +23,7 @@
@Override
protected void executeCommand() {
log.infoFormat("ConnectDomainToStorage. Before Connect all hosts to
pool. Time:{0}", new Date());
- connectAllHostsToPool();
+ connectHostsInUpToDomainStorageServer();
log.infoFormat("ConnectDomainToStorage. After Connect all hosts to
pool. Time:{0}", new Date());
}
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
index ec338ef..440e5d8 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
@@ -47,7 +47,7 @@
changeStorageDomainStatusInTransaction(getStorageDomain().getStoragePoolIsoMapData(),
StorageDomainStatus.Detaching);
log.info(" Detach storage domain: before connect");
- connectAllHostsToPool();
+ connectHostsInUpToDomainStorageServer();
log.info(" Detach storage domain: after connect");
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
index 8e77b79..dd0b155 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
@@ -329,7 +329,7 @@
}
}
- protected List<Pair<Guid, Boolean>> connectAllHostsToPool() {
+ protected List<Pair<Guid, Boolean>>
connectHostsInUpToDomainStorageServer() {
List<VDS> hostsInStatusUp = getAllRunningVdssInPool();
List<Callable<Pair<Guid, Boolean>>> callables = new LinkedList<>();
for (final VDS vds : hostsInStatusUp) {
diff --git
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
index c6e0f82..e36ee52 100644
---
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
+++
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
@@ -88,7 +88,7 @@
doReturn(dbFacade).when(cmd).getDbFacade();
doNothing().when(cmd).attemptToActivateDomain();
- doReturn(Collections.emptyList()).when(cmd).connectAllHostsToPool();
+
doReturn(Collections.emptyList()).when(cmd).connectHostsInUpToDomainStorageServer();
when(dbFacade.getStoragePoolIsoMapDao()).thenReturn(isoMapDAO);
when(dbFacade.getStoragePoolDao()).thenReturn(storagePoolDAO);
when(dbFacade.getVdsDao()).thenReturn(vdsDAO);
--
To view, visit http://gerrit.ovirt.org/31273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15b3cfc6f4a08350b16f252df2587bd2c7737ebe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
