Gilad Chaplik has posted comments on this change. Change subject: webadmin: introduce disk profiles ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/29672/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/DiskProfileListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/DiskProfileListModel.java: Line 109: if (getEntity() == null) { Line 110: return; Line 111: } Line 112: Frontend.getInstance().runQuery(VdcQueryType.GetAllQosByStoragePoolIdAndType, Line 113: new QosQueryParameterBase(getEntity().getStoragePoolId(), QosType.STORAGE), getEntity().getStoragePoolId() can be null, incase the sd is unattached. will fix in next patch set. Line 114: new AsyncQuery(new INewAsyncCallback() { Line 115: @Override Line 116: public void onSuccess(Object model, Object returnValue) { Line 117: List<StorageQos> qosList = -- To view, visit http://gerrit.ovirt.org/29672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5cea3c563cf68efca0468749338a532894f709 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
